Skip to content

Case change and and 'none' reset option for Digistump Oak #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 15, 2018
Merged

Case change and and 'none' reset option for Digistump Oak #4143

merged 5 commits into from
Jan 15, 2018

Conversation

pfeerick
Copy link
Contributor

@pfeerick pfeerick commented Jan 12, 2018 •
edited
Loading

The logo is 'digiStump', but is always written in text form as 'Digistump'.

The generator fixed an issue with the release version of 2.4.0 not having a resetMethod for the Digistump Oak, and hence not being able to be uploaded to without modifying the boards.txt file. However, the Oak doesn't support auto-reset via serial - it was primarily designed to be a cloud-programmed board. Hence the addition of another resetMacro macro.

@pfeerick
Case change and and 'none' reset option for Digistump Oak
3bead42 
The logo is 'digiStump', but is always written in text form as 'Digistump'. 

The generator fixed an issue with the release version of 2.4.0 not having a resetMethod for the Digistump Oak, and hence not being able to be uploaded to without modifying the boards.txt file. However, the Oak doesn't support auto-reset via serial - it was primarily designed to be a cloud-programmed board.
d-a-v
d-a-v approved these changes Jan 12, 2018
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably should also regenerate boards.txt and add it in the commit.

@pfeerick
Copy link
Contributor Author

Damn github, should've done the changes to the local repo and pushed it from there, instead of editing directly on the github page in the first instance.

@pfeerick
Copy link
Contributor Author

I noticed some minor formatting corrections that I was going to do related to the Oak section of docs/boards.rst (title, fix link to serial adapter heading), but I'm not sure if the boards.txt.py generation is working properly or if boards.rst has been generated by it yet? As what should have been only a change to two lines has done a LOT of changes when running --docgen ?

@d-a-v
Copy link
Collaborator

d-a-v commented Jan 15, 2018

You are right, boards.rst is still the original one and has not yet been generated. The generator is quite fresh and the only generated data we use so far is boards.txt.
This explains the lot of changes.
So while you are at it, then yes please do the commit.

@pfeerick
Regeneration of doc/boards.rst
c236067 
Minor formatting change to Digistump Oak section and
regeneration of the doc/boards.rst
@pfeerick
Copy link
Contributor Author

Just mentioning this PR here as the regen of boards.rst, if all is good, should close #4083 as well.

@d-a-v d-a-v merged commit 12f336f into esp8266:master Jan 15, 2018
@pfeerick
Copy link
Contributor Author

pfeerick commented Jan 15, 2018 •
edited
Loading

Just a few final bits! :-O lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfeerick @d-a-v